jh163888/xrdp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "devredir: fix xinode leak"

Browse Source 
This reverts commit 5daa09171e.

Causes "double free". Fix #990 was not correct.

```
[1271363627]: DEV_REDIR  dev_redir_proc_device_iocompletion: 738 : entered: IoStatus=0x0 CompletionId=1
[1271363627]: DEV_REDIR  dev_redir_proc_device_iocompletion: 839 : got CID_DIRECTORY_CONTROL
[1271363627]: DEV_REDIR  dev_redir_proc_query_dir_response: 933 : processing FILE_DIRECTORY_INFORMATION structs
[1271363627]: DEV_REDIR  dev_redir_proc_query_dir_response: 968 : FileName:          .
[1271363627]: DEV_REDIR  devredir_fuse_data_peek: 1335 : returning 0x7f2a9c013410
*** Error in `/usr/sbin/xrdp-chansrv': double free or corruption (out): 0x00007f2a9c13a330 ***
```

Closes: #1025
This commit is contained in:
Koichiro IWAO 2018-03-22 12:37:42 +09:00
parent a432969746
commit 780ba744f6
No known key found for this signature in database
GPG Key ID: 9F72CDBC01BF10EB
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sesman/chansrv/devredir.c
View File

@ -986,8 +986,6 @@ dev_redir_proc_query_dir_response(IRP *irp,
/* add this entry to xrdp file system */ /* add this entry to xrdp file system */
fuse_data = devredir_fuse_data_peek(irp); fuse_data = devredir_fuse_data_peek(irp);
xfuse_devredir_cb_enum_dir(fuse_data->data_ptr, xinode); xfuse_devredir_cb_enum_dir(fuse_data->data_ptr, xinode);
g_free(xinode);
} }
dev_redir_send_drive_dir_request(irp, DeviceId, 0, NULL); dev_redir_send_drive_dir_request(irp, DeviceId, 0, NULL);