jh163888/xrdp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Call auth_end() exactly once in scp_v0_process()

Browse Source 
As discovered by Valgrind, it wasn't called at all in case of a
successful session creation, which leaked memory.
This commit is contained in:
Pavel Roskin 2016-10-16 23:40:54 -07:00
parent 65ac8e758b
commit e17a56efb6
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sesman/scp_v0.c
View File

@ -68,8 +68,6 @@ scp_v0_process(struct SCP_CONNECTION *c, struct SCP_SESSION *s)
s->username); s->username);
scp_v0s_replyauthentication(c, errorcode); scp_v0s_replyauthentication(c, errorcode);
} }
auth_end(data);
} }
else if (data) else if (data)
{ {
@ -94,8 +92,6 @@ scp_v0_process(struct SCP_CONNECTION *c, struct SCP_SESSION *s)
} }
session_reconnect(display, s->username); session_reconnect(display, s->username);
auth_end(data);
/* don't set data to null here */
} }
else else
{ {
@ -148,7 +144,6 @@ scp_v0_process(struct SCP_CONNECTION *c, struct SCP_SESSION *s)
if (display == 0) if (display == 0)
{ {
auth_end(data);
scp_v0s_deny_connection(c); scp_v0s_deny_connection(c);
} }
else else
@ -160,4 +155,5 @@ scp_v0_process(struct SCP_CONNECTION *c, struct SCP_SESSION *s)
{ {
scp_v0s_deny_connection(c); scp_v0s_deny_connection(c);
} }
auth_end(data);
} }