Pavel Roskin
6664aac00f
Use "void" for empty argument list in declarations
...
In C, an empty argument list in a declaration means that the function
can accept any arguments. Use "void" instead, it means "no arguments".
C++ treats void and empty list as "no arguments".
2017-01-05 17:27:20 -08:00
volth
26a26ef906
fix build with --enable-xrdpdebug=yes
2017-01-04 19:20:44 +00:00
volth
37b4a14b54
fix build with --enable-xrdpdebug=yes
2017-01-04 13:00:01 +00:00
Pavel Roskin
c21b9a78f4
Distribute all files except git and github specific data
...
It is better to distribute a few useless file than not to distribute
needed files.
2016-12-18 00:00:11 -08:00
Pavel Roskin
e46d15ca84
Fix C++ errors and warnings in FUSE code
2016-11-26 09:17:51 -08:00
Pavel Roskin
2ab321a7c6
Use fuse_ino_t for FUSE inodes, not tui32 or int
2016-11-26 09:17:51 -08:00
Pavel Roskin
f622a17c75
Remove write-only FileId variable
2016-11-26 09:17:51 -08:00
Pavel Roskin
46f4025372
Cast pointer to uint64_t through tintptr to avoid warnings
...
Cast to long would damage a pointer on Win64.
2016-11-26 09:17:51 -08:00
Pavel Roskin
e92c4f3b40
Use constant strings to fix warnings
2016-11-26 09:17:51 -08:00
Pavel Roskin
662172012b
Call devredir_cvt_slash() on the path copy, it changes the argument
2016-11-26 09:17:51 -08:00
Pavel Roskin
a4e3952d65
Disable or remove dead code to prevent it from throwing warnings
2016-11-26 09:17:51 -08:00
Pavel Roskin
a547cc3784
Include needed files in chansrv_fuse.c, remove duplicate declarations
2016-11-26 09:17:51 -08:00
Pavel Roskin
bf39fed6e4
Fix misuse of NULL for arithmetic type
2016-11-26 09:17:51 -08:00
Pavel Roskin
4234ed278e
Use FUSE_CFLAGS and FUSE_LIBS from pkg-config
...
Include <fuse_lowlevel.h>, not <fuse/fuse_lowlevel.h>, the include path
should be set up for that.
Don't define _FILE_OFFSET_BITS in one file, FUSE_CFLAGS would enable it
for the whole xrdp-chansrv build if needed.
2016-11-26 09:17:51 -08:00
Pavel Roskin
7fce469cbc
Fix format warnings if FUSE is enabled
2016-11-21 17:51:20 +00:00
Jay Sorg
25fd585d55
chansrv: some fixes to log file path
2016-11-19 07:31:36 +00:00
metalefty
b89956d06e
Merge pull request #485 from proski/code-standards
...
Code standards
2016-11-16 17:05:21 +09:00
Pavel Roskin
35b336272b
Fix compilation with C++
2016-11-15 22:40:06 -08:00
Pavel Roskin
16c3bbdb8d
Remove all tabs in sources
2016-11-15 22:40:06 -08:00
Pavel Roskin
92423a466e
Fix potential buffer overflow in strncat() invocation
...
strncat() will copy at most the specified number of characters and append
the null character on top of that. strlen() doesn't count the final null
character.
2016-11-15 22:38:21 -08:00
Koichiro IWAO
7d017482f6
chansrv: change chansrv log path to ${XDG_DATA_HOME}/xrdp
...
like Xorg's logfile is written to ${XDG_DATA_HOME}/xorg/Xorg.n.log.
If XDG_DATA_HOME is not defined, the log path will be
${HOME}/.local/share/xrdp.
2016-10-25 14:52:43 +09:00
Pavel Roskin
a370306f75
Get rid of EXTRA_LIBS, use variables with more specific names
2016-10-20 10:43:02 -07:00
Pavel Roskin
5c69f3cd57
Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGS
2016-10-20 10:43:02 -07:00
Pavel Roskin
0422734fc7
Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGS
...
AM_CPPFLAGS is a documented Automake variable for C preprocessor flags
that should not be overridden when compiling the package.
There is no need to have two additional variables that are ultimately
merged into AM_CPPFLAGS.
Their names are also confusing. EXTDA_DIST is a documented Automake
variable. Everything else that starts with "EXTRA" is not.
2016-10-20 10:43:02 -07:00
Pavel Roskin
a618d4f757
Don't use final newline in log calls, it's already appended
2016-10-17 08:54:07 -07:00
Koichiro IWAO
9f277e4445
chansrv: pathname also should be URL decoded
...
because 1st argument to clipboard_get_file() is given as URL encoded.
Decoding only filename is incomplete.
Without this fix, clipboard file doesn't work in case pathname
contains non-ASCII characters or non-alphanumeric ASCII characters.
2016-08-30 15:49:58 +09:00
jsorg71
8353baab3d
Merge pull request #390 from proski/june21
...
Cleanups and C++ compatibility
2016-08-05 14:38:41 -07:00
Kentaro Hayashi
8f3fb2f7c8
chansrv: avoid chansrv SEGV when xinode is NULL
...
When xfuse_create_file_in_xrdp_fs is failed, it returns NULL.
Without this fix, xinode->size causes SEGV, so implementation is changed
to return -1 and check the return value in caller.
2016-07-21 16:02:21 +09:00
Jay Sorg
9ccbfb6985
chansrv: added mp3 compression from Speidy
2016-07-13 17:44:07 -07:00
Pavel Roskin
2c13ef5c6d
Use enum logLevels consistently for log levels
2016-07-08 04:29:57 +00:00
Pavel Roskin
cbe413bd8b
Fix return type of devredir_fuse_data_peek and devredir_fuse_data_dequeue
2016-07-08 04:29:56 +00:00
Pavel Roskin
d1efb0d5ba
Fix signed to unsigned comparisons reported by g++ 6.1.0
2016-07-08 04:29:51 +00:00
Pavel Roskin
5829323ad8
Use g_new or g_new0 when C++ compiler would complain about implicit cast
2016-07-08 04:29:49 +00:00
Pavel Roskin
4b05bb2ebd
Mark g_drdynvc_chan_id as extern in g_drdynvc_chan_id, it's in chansrv.c
2016-07-08 04:29:44 +00:00
Pavel Roskin
aaa89ad4e6
Use const unsigned for hex arrays
...
Some constants are too big for the signed type.
2016-07-08 04:29:43 +00:00
Pavel Roskin
aeeb3d2c2e
Fix warnings detected by -Wwrite-strings
2016-07-08 04:29:42 +00:00
Pavel Roskin
77b380c0b5
Fix format warnings in log_message() calls
2016-06-21 16:30:16 -07:00
Pavel Roskin
1403652c72
Remove unused variable in devredir_cvt_from_unicode_len()
2016-05-06 18:58:16 -07:00
Pavel Roskin
f2d326cbed
Remove unused variables from dev_redir_proc_query_dir_response()
2016-05-06 18:58:16 -07:00
Pavel Roskin
0dd0426e6f
Check XGetWindowProperty() return code in clipboard_event_property_notify()
2016-05-06 18:31:03 -07:00
Pavel Roskin
72019d3611
Use better symbols to protect include files
2016-05-05 00:06:26 -07:00
Pavel Roskin
ca9cbcafc8
Typo fixes
2016-05-04 23:33:30 -07:00
Pavel Roskin
70f3d4c5e2
Fix warnings for unused variables read from byte streams
2016-04-23 00:18:38 -07:00
Pavel Roskin
0629b25d5f
Fix warnings about unused variables and functions
2016-04-21 22:27:27 -07:00
Pavel Roskin
e65bd6b7d7
Fix more format warnings
2016-04-21 21:21:17 -07:00
Jay Sorg
7393579205
Don't attempt to intercept SIGKILL, it doesn't work on any OS
2016-03-14 16:33:49 -07:00
jsorg71
f53b3bb737
Merge pull request #326 from metalefty/pulseaudio-6.0
...
pulse: fix build pulseaudio 6.0 or higher
2016-02-23 23:19:59 -08:00
Pavel Roskin
59a5fb0ddb
Move headers from EXTRA_DIST to sources, sort alphabetically
...
There should be no functional difference.
2016-02-21 23:06:48 -08:00
Koichiro IWAO
93f7bcb71b
pulse: fix build pulseaudio 6.0 or higher
...
Discovered in #321 . The number of argument for pa_rtpoll_run have
been changed since 6.0.
>=6.0 : int pa_rtpoll_run(pa_rtpoll *f);
<6.0 : int pa_rtpoll_run(pa_rtpoll *f, bool wait);
Check pulseaudio version by PA_CHECK_VERSION macro introduced since
pulseaudio 0.9.16. In case PA_CHECK_VERSION is not defined,
pa_rtpoll_run takes 2 arguments.
2016-02-18 00:45:33 +09:00
Pavel Roskin
92a6833e9b
Fix typos
2016-02-13 20:41:07 -08:00