1. Add brackets round if bodies.
2. Use common os_calls/thread_calls functions where available and add
new ones for:
g_file_seek_rel_end()
g_map_file_shared()
g_unmap_file_shared()
g_sleep_secs() [because usleep() can error for argument >= 1M]
g_ftruncate()
tc_mutex_timed_lock()
tc_shared_mutex_create()
3. Separate declarations and initialisations.
4. Make macros for sesshm_try_lock() etc cleaner.
Also some minor bugfixes:
1. Fix bug in sesshm_try_lock() which begins "return 0".
2. The return value of pthread_mutex_init() in sesshm_create_new_shm()
was ignored. (No longer relevant because tc_shared_mutex_create() is
now used.)
3. sesshm_map() set g_shm_mapping and returned a value. (No longer
relevant because using g_map_file_shared() it is simple enough not to
need a function.)
Allow xrdp-sesman to discover sessions still running that were created
by a previous xrdp-sesman process.
Implement this using a file-backed shared mmap region, visible to both
the daemon and session instances of xrdp-sesman. Add a heartbeat
timestamp updated by the session instance so that the daemon instance
can infer whether the sessions in the mmap region are current or stale.
The shared memory can also be used to pass other data between daemon and
session instances, for example the session's idle time.
Add locking around access to g_sessions and the mmap region. This is a
PTHREAD_PROCESS_SHARED lock which protects shared memory used by
separate processes. Defining DEBUG_SESSION_LOCK enables logging to help
debug locking bugs.
Notes:
1. The number of sessions is limited by the size of the array in shared
memory, SESMAN_SHAREDMEM_MAX_SESSIONS. This could be made dynamic
instead by growing the file and the mmap region.
2. If sesshm_try_open_existing_shm() finds a shm file but it looks
wrong, it creates a new one. Perhaps it should instead exit with an
error?
3. In sesshm_thread() if the session xrdp-sesman notices that it has
been removed from the daemon's list it exits. It should kill the X
server and/or window manager first.
4. This doesn't yet update idle times. I need to work out how to get
this information from the X server.
5. This uses an array of sessions in the mmap region so the linked list
g_sessions might be redundant now.
6. Defining DONT_USE_SHM will let xrdp-sesman run without creating or
trying to use the mmap file. This could be removed in the future.
7. I think the locking fixes an theorised bug where a session can be
removed from the g_sessions linked list in session_kill() (called from
the signal handler) at the same time as a session is added in
session_start_fork().
linux/vm_sockets.h defines VMADDR_CID_ANY and VMADDR_PORT_ANY (both
equal to -1U) for vsock cid and port respectively. This change aims to
add the capability to parse negative cid and port numbers for vsock from
the config and pass them to the kernel.
Allows for valid configurations such as "port=vsock://-1:3389" to be
correctly processed, but will parse port and cid inputs like "---1" to
"-", which should currently get silently turned into 0 by atoi inside
g_sck_vsock_bind_address. Inputs that do not contain "-" get parsed as
by xrdp_listen_parse_integer.
